Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] fix ever-accumulating memory in logger #5285

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5284

/assign nojnhuh

Fixed an issue where CAPZ was accumulating memory over time that could never be garbage collected.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2024
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45864ae5e2191efdac1b72e9f4d7964d4455eb18

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 18, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.35%. Comparing base (30592f6) to head (bf6d8f2).
Report is 5 commits behind head on release-1.16.

Files with missing lines Patch % Lines
util/tele/span_logger.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.16    #5285      +/-   ##
================================================
- Coverage         52.82%   52.35%   -0.48%     
================================================
  Files               273      273              
  Lines             29143    29147       +4     
================================================
- Hits              15394    15259     -135     
- Misses            12947    13087     +140     
+ Partials            802      801       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 18, 2024

/retest

3 similar comments
@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 18, 2024

/retest

@jackfrancis
Copy link
Contributor

/retest

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 19, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 73149fb into kubernetes-sigs:release-1.16 Nov 19, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants