-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cert manager is only installed if version mismatch or not yet installed #5278
cert manager is only installed if version mismatch or not yet installed #5278
Conversation
Welcome @audrastump! |
Hi @audrastump. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test (Although nothing can actually test changes to the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5278 +/- ##
==========================================
- Coverage 52.78% 52.43% -0.35%
==========================================
Files 270 272 +2
Lines 29057 29401 +344
==========================================
+ Hits 15337 15417 +80
- Misses 12928 13178 +250
- Partials 792 806 +14 ☔ View full report in Codecov by Sentry. |
/retest |
Update Tiltfile Update Tiltfile
8c1777b
to
90d711d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you!
LGTM label has been added. Git tree hash: 69ff3bdf6db611eb066d1c9d6176ed1a74d4a686
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixing issue #5267 where Tilt reinstalls cert-manager on every deployment
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5267
Special notes for your reviewer:
TODOs:
Release note: