Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template/flatcar-sysext: use marketplace images #5263

Merged
merged 1 commit into from
Nov 19, 2024
Merged

template/flatcar-sysext: use marketplace images #5263

merged 1 commit into from
Nov 19, 2024

Conversation

tormath1
Copy link
Contributor

Gallery images was the solution used for publishing Flatcar CAPZ images. We can now directly use marketplace images as Flatcar sysext template does not need images from the image-builder but can use a regular Flatcar images (which is automatically published at each release)

What type of PR is this?

/kind cleanup

What this PR does / why we need it: Change the source of Flatcar images from gallery to marketplace (which is more up to date)

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Use regular Flatcar images from Azure marketplace for flatcar-sysext template

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.00%. Comparing base (7e9ebb9) to head (2ccc908).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5263   +/-   ##
=======================================
  Coverage   53.00%   53.00%           
=======================================
  Files         272      272           
  Lines       29429    29429           
=======================================
  Hits        15598    15598           
  Misses      13027    13027           
  Partials      804      804

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@tormath1
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@tormath1 tormath1 force-pushed the tormath1/flatcar-marketplace branch from fcc1c02 to 7cff864 Compare November 12, 2024 13:51
@tormath1
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@tormath1
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-windows-custom-builds

1 similar comment
@tormath1
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-windows-custom-builds

mboersma
mboersma approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 388ab402ddf990e55dd8e85821ef283ca0ba75f8

@mboersma
Copy link
Contributor

/retest

I don't think the -windows-custom-builds failure is related, but let's try it once more.

@tormath1
Copy link
Contributor Author

/retest

I don't think the -windows-custom-builds failure is related, but let's try it once more.

@mboersma Me neither... but that's weird. That said, I see the same kind of issues on this PR for example: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5272/pull-cluster-api-provider-azure-windows-with-ci-artifacts/1857131767895429120

@tormath1
template/flatcar-sysext: use marketplace images
2ccc908 
Gallery images was the solution used for publishing Flatcar CAPZ images.
We can now directly use marketplace images as Flatcar sysext template does not
need images from the image-builder but can use a regular Flatcar images
(which is automatically published at each release)

Signed-off-by: Mathieu Tortuyaux <[email protected]>
@tormath1 tormath1 force-pushed the tormath1/flatcar-marketplace branch from 7cff864 to 2ccc908 Compare November 18, 2024 13:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2024
@mboersma
Copy link
Contributor

/retest

@tormath1
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

/retest

@mboersma
Copy link
Contributor

/override pull-cluster-api-provider-azure-windows-with-ci-artifacts pull-cluster-api-provider-azure-windows-custom-builds

@k8s-ci-robot
Copy link
Contributor

@mboersma: Overrode contexts on behalf of mboersma: pull-cluster-api-provider-azure-windows-custom-builds, pull-cluster-api-provider-azure-windows-with-ci-artifacts

In response to this:

/override pull-cluster-api-provider-azure-windows-with-ci-artifacts pull-cluster-api-provider-azure-windows-custom-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mboersma
mboersma approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8703d3df3bfe5994380a59ba84a0686b73699028

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8e06caf into kubernetes-sigs:main Nov 19, 2024
31 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 19, 2024
@tormath1 tormath1 deleted the tormath1/flatcar-marketplace branch November 20, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@tormath1 @k8s-ci-robot @mboersma