Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid caBundle from CRDs #5172

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 11, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

This change removes invalid caBundles from our CRDs to enable running CAPZ in a Kubernetes 1.31 management cluster per the CAPI migration guide to 1.8: https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.7-to-v1.8

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 11, 2024

/cherry-pick release-1.17

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2024
@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackfrancis
Copy link
Contributor

Can we cherry-pick this into v1.16 as well?

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.35%. Comparing base (da6ca56) to head (b4ca0dc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5172   +/-   ##
=======================================
  Coverage   51.35%   51.35%           
=======================================
  Files         273      273           
  Lines       24670    24670           
=======================================
  Hits        12670    12670           
  Misses      11211    11211           
  Partials      789      789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 11, 2024

Yeah that should be fine. I was naively associating this only with CAPI 1.8 (which we don't import on our 1.16 branch) but I don't see where that would actually matter assuming this doesn't break any tests.

/cherry-pick release-1.16

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

Yeah that should be fine. I was naively associating this only with CAPI 1.8 (which we don't import on our 1.16 branch) but I don't see where that would actually matter assuming this doesn't break any tests.

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 966371fa550364b5a0330028d2de20f102209927

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 11, 2024

/retest

1 similar comment
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 11, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 76a735b into kubernetes-sigs:main Oct 11, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Oct 11, 2024
@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #5174

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #5175

In response to this:

Yeah that should be fine. I was naively associating this only with CAPI 1.8 (which we don't import on our 1.16 branch) but I don't see where that would actually matter assuming this doesn't break any tests.

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants