-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove invalid caBundle from CRDs #5172
Conversation
/cherry-pick release-1.17 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can we cherry-pick this into v1.16 as well? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5172 +/- ##
=======================================
Coverage 51.35% 51.35%
=======================================
Files 273 273
Lines 24670 24670
=======================================
Hits 12670 12670
Misses 11211 11211
Partials 789 789 ☔ View full report in Codecov by Sentry. |
Yeah that should be fine. I was naively associating this only with CAPI 1.8 (which we don't import on our 1.16 branch) but I don't see where that would actually matter assuming this doesn't break any tests. /cherry-pick release-1.16 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 966371fa550364b5a0330028d2de20f102209927
|
/retest |
1 similar comment
/retest |
@nojnhuh: new pull request created: #5174 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@nojnhuh: new pull request created: #5175 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This change removes invalid
caBundle
s from our CRDs to enable running CAPZ in a Kubernetes 1.31 management cluster per the CAPI migration guide to 1.8: https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.7-to-v1.8Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: