Update golangci-lint and add golangci-lint GitHub workflow

[nawazkh]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

• This PR updates golangci-lint to 1.60.2
• Adds pr-golangci-lint job to the repo.
• Removes golangci-lint from make test target so that make test solely focuses on test coverage and not on linter signal.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5110

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Update Golangci-lint to v1.60.2 and add golangci-lint PR GitHub workflow

[codecov]

Codecov Report

Attention: Patch coverage is 50.71429% with 69 lines in your changes missing coverage. Please review.

Project coverage is 51.34%. Comparing base (553cd0f) to head (97b2c12).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
exp/controllers/helpers.go	46.15%	6 Missing and 1 partial ⚠️
api/v1alpha1/azureasomanagedcluster_webhook.go	0.00%	3 Missing ⚠️
...pi/v1alpha1/azureasomanagedcontrolplane_webhook.go	0.00%	3 Missing ⚠️
api/v1alpha1/azureasomanagedmachinepool_webhook.go	0.00%	3 Missing ⚠️
azure/services/privatedns/record_client.go	0.00%	3 Missing ⚠️
internal/test/record/logger.go	0.00%	2 Missing and 1 partial ⚠️
...1beta1/azuremanagedcontrolplanetemplate_webhook.go	50.00%	2 Missing ⚠️
...v1beta1/azuremanagedmachinepooltemplate_webhook.go	50.00%	2 Missing ⚠️
azure/scope/machinepool.go	33.33%	2 Missing ⚠️
azure/services/availabilitysets/client.go	0.00%	2 Missing ⚠️
... and 37 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5158      +/-   ##
==========================================
- Coverage   51.36%   51.34%   -0.02%     
==========================================
  Files         273      273              
  Lines       24676    24671       -5     
==========================================
- Hits        12674    12668       -6     
- Misses      11212    11214       +2     
+ Partials      790      789       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nawazkh]

linter is green locally, waiting for the tests to be green.

[nawazkh]

pull-cluster-api-provider-azure-load-test-custom-builds test job complains the below

./scripts/../scripts/ci-build-azure-ccm.sh: line 48: pushd: /home/prow/go/src/sigs.k8s.io/cloud-provider-azure: No such file or directory
Image registry is capzcicommunity.azurecr.io
./scripts/../scripts/ci-build-azure-ccm.sh: line 52: IMAGE_TAG_CCM: unbound variable

---

IMAGE_TAG_CCM gets defaulted at line 48

cluster-api-provider-azure/scripts/ci-build-azure-ccm.sh

Lines 48 to 50 in 80fca66

	pushd "${AZURE_CLOUD_PROVIDER_ROOT}" && IMAGE_TAG=$(git rev-parse --short=7 HEAD) &&
	IMAGE_TAG_CCM="${IMAGE_TAG_CCM:-${IMAGE_TAG}}" && IMAGE_TAG_CNM="${IMAGE_TAG_CNM:-${IMAGE_TAG}}" &&
	export IMAGE_TAG_CCM && export IMAGE_TAG_CNM && popd

, so this error doesn't seem to be the root cause.

Did something change at prow that is keeping AZURE_CLOUD_PROVIDER_ROOT empty ?
Is this /home/prow/go/src/sigs.k8s.io/cloud-provider-azure supposed to exist at prow?

[nawazkh]

Message: The storage account named capzcioidcissuer12063 is already taken. for pull-cluster-api-provider-azure-e2e-aks :/

/test pull-cluster-api-provider-azure-e2e-aks

[nawazkh]

/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts

[nawazkh]

/test pull-cluster-api-provider-azure-e2e

[nawazkh]

hold for squash
/hold

[nawazkh]

squashed all the commits.
/unhold

[k8s-ci-robot]

@nawazkh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-load-test-custom-builds	97b2c12	link	false	/test pull-cluster-api-provider-azure-load-test-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Jont828]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 03f914c797ea53c9e1e0ca38c5100572cef38615

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Jont828]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment