move ASOAPI out of experimental

[nojnhuh]

What type of PR is this?
/kind feature

What this PR does / why we need it:

This PR moves the functionality gated by the ASOAPI feature flag out of exp/ and enables the flag by default. The APIs themselves are still v1alpha1.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

The `ASOAPI` feature flag is now enabled by default. The API version of those resources is still `v1alpha1`.

[nojnhuh]

Locally, git tells me the diff here is just that some of the webhooks got reordered with no other changes:

diff --git a/config/webhook/manifests.yaml b/config/webhook/manifests.yaml
index ef0911274..de5ab8e64 100644
--- a/config/webhook/manifests.yaml
+++ b/config/webhook/manifests.yaml
@@ -204,6 +204,66 @@ kind: ValidatingWebhookConfiguration
 metadata:
   name: validating-webhook-configuration
 webhooks:
+- admissionReviewVersions:
+  - v1
+  - v1beta1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcluster
+  failurePolicy: Fail
+  name: validation.azureasomanagedcluster.infrastructure.cluster.x-k8s.io
+  rules:
+  - apiGroups:
+    - infrastructure.cluster.x-k8s.io
+    apiVersions:
+    - v1alpha1
+    operations:
+    - CREATE
+    resources:
+    - azureasomanagedclusters
+  sideEffects: None
+- admissionReviewVersions:
+  - v1
+  - v1beta1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcontrolplane
+  failurePolicy: Fail
+  name: validation.azureasomanagedcontrolplane.infrastructure.cluster.x-k8s.io
+  rules:
+  - apiGroups:
+    - infrastructure.cluster.x-k8s.io
+    apiVersions:
+    - v1alpha1
+    operations:
+    - CREATE
+    resources:
+    - azureasomanagedcontrolplanes
+  sideEffects: None
+- admissionReviewVersions:
+  - v1
+  - v1beta1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedmachinepool
+  failurePolicy: Fail
+  name: validation.azureasomanagedmachinepool.infrastructure.cluster.x-k8s.io
+  rules:
+  - apiGroups:
+    - infrastructure.cluster.x-k8s.io
+    apiVersions:
+    - v1alpha1
+    operations:
+    - CREATE
+    resources:
+    - azureasomanagedmachinepools
+  sideEffects: None
 - admissionReviewVersions:
   - v1
   - v1beta1
@@ -442,66 +502,6 @@ webhooks:
     resources:
     - azuremanagedmachinepooltemplates
   sideEffects: None
-- admissionReviewVersions:
-  - v1
-  - v1beta1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcluster
-  failurePolicy: Fail
-  name: validation.azureasomanagedcluster.infrastructure.cluster.x-k8s.io
-  rules:
-  - apiGroups:
-    - infrastructure.cluster.x-k8s.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    resources:
-    - azureasomanagedclusters
-  sideEffects: None
-- admissionReviewVersions:
-  - v1
-  - v1beta1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedcontrolplane
-  failurePolicy: Fail
-  name: validation.azureasomanagedcontrolplane.infrastructure.cluster.x-k8s.io
-  rules:
-  - apiGroups:
-    - infrastructure.cluster.x-k8s.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    resources:
-    - azureasomanagedcontrolplanes
-  sideEffects: None
-- admissionReviewVersions:
-  - v1
-  - v1beta1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /validate-infrastructure-cluster-x-k8s-io-v1alpha1-azureasomanagedmachinepool
-  failurePolicy: Fail
-  name: validation.azureasomanagedmachinepool.infrastructure.cluster.x-k8s.io
-  rules:
-  - apiGroups:
-    - infrastructure.cluster.x-k8s.io
-    apiVersions:
-    - v1alpha1
-    operations:
-    - CREATE
-    resources:
-    - azureasomanagedmachinepools
-  sideEffects: None
 - admissionReviewVersions:
   - v1
   - v1beta1

[nojnhuh]

This is the controller that does the automatic adoption of AKS clusters into the ASO API which hasn't been tested as thoroughly yet as the actual API, so I could see where we might still want this under exp/. Would we want to add a separate feature flag just for the adoption controllers that we leave off by default so we can still enable the rest of the ASO API by default?

[nojnhuh]

/milestone v1.16
/assign @jackfrancis @nawazkh

[codecov]

Codecov Report

Attention: Patch coverage is 43.15789% with 54 lines in your changes missing coverage. Please review.

Project coverage is 62.24%. Comparing base (6b352b6) to head (d3a3fc5).

Files	Patch %	Lines
controllers/azureasomanagedcluster_controller.go	40.90%	12 Missing and 1 partial ⚠️
controllers/managedclusteradopt_controller.go	0.00%	13 Missing ⚠️
controllers/agentpooladopt_controller.go	0.00%	12 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go	57.14%	8 Missing and 1 partial ⚠️
...ntrollers/azureasomanagedmachinepool_controller.go	53.33%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4969      +/-   ##
==========================================
- Coverage   62.25%   62.24%   -0.02%     
==========================================
  Files         201      201              
  Lines       16912    16912              
==========================================
- Hits        10529    10527       -2     
- Misses       5590     5592       +2     
  Partials      793      793              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jackfrancis]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 946a2733d6fc6d9dfa8ef0870dbc9fe3e14abcdc

[nawazkh]

Just one comment, overall looks good to me.
/lgtm

[nawazkh]

Is mutators also part of this graduation ?

[nojnhuh]

Yes, that defines some supporting code for the rest of the ASOAPI things.

[nojnhuh]

I didn't actually hit any conflicts?
/hold for squash

[nojnhuh]

/test pull-cluster-api-provider-azure-e2e-aks

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2a8304dacfeb1a329caaf4a7a9ab18b83f643e30

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nojnhuh]

squashed!
/hold cancel

[k8s-ci-robot]

@nojnhuh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-e2e-with-wi-optional	9c51d1b	link	false	/test pull-cluster-api-provider-azure-e2e-with-wi-optional
pull-cluster-api-provider-azure-apidiff	d3a3fc5	link	false	/test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.