Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] Bump CAPI to v1.7.3 #4919

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[release-1.15] Bump CAPI to v1.7.3 #4919

merged 1 commit into from
Jun 12, 2024

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Manual cherry-pick of #4915

Updates CAPI to v1.7.3. Also bumps cert-manager to v1.15.0 to stay in sync with CAPI.

Which issue(s) this PR fixes:

N/A, but see #4858 for prior art.

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump CAPI to v1.7.3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2024
@mboersma mboersma changed the title Bump CAPI to v1.7.3 [release-1.15] Bump CAPI to v1.7.3 Jun 11, 2024
nojnhuh
nojnhuh approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1ab171fe54fa9951f7bbf0a68fe4b5eb7c180c7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (70349a9) to head (055de11).
Report is 1 commits behind head on release-1.15.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.15    #4919   +/-   ##
=============================================
  Coverage         62.01%   62.01%           
=============================================
  Files               201      201           
  Lines             16861    16861           
=============================================
  Hits              10456    10456           
  Misses             5622     5622           
  Partials            783      783

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma mboersma force-pushed the capi-vee-one-seven-three-release-1.15 branch from 3b6f6cd to 055de11 Compare June 12, 2024 13:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from nojnhuh June 12, 2024 13:17
@mboersma
Copy link
Contributor Author

I updated this to remove my (incomplete) change to OLD_PROVIDER_UPGRADE_VERSION: apparently we haven't been updating those versions in release branches, just in main. 🤷

@nojnhuh
Copy link
Contributor

nojnhuh commented Jun 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dafb8b016ccaf58f0c8a9d12e6d83da3dab7e809

@nojnhuh
Copy link
Contributor

nojnhuh commented Jun 12, 2024

/retest

@nojnhuh
Copy link
Contributor

nojnhuh commented Jun 12, 2024

unlucky region roulette on this PR...
/retest

@k8s-ci-robot k8s-ci-robot merged commit 7179027 into kubernetes-sigs:release-1.15 Jun 12, 2024
19 checks passed
@mboersma mboersma deleted the capi-vee-one-seven-three-release-1.15 branch June 12, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@marosset marosset Awaiting requested review from marosset

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mboersma @k8s-ci-robot @nojnhuh