Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Set cluster name label for pre-existing kubeconfig #4847

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #4833

/assign willie-yao

Set cluster name label for pre-existing kubeconfig

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented May 14, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5dd49177f3a793d240cd0cfc1f7d1ae02fc18160

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented May 14, 2024

/approve cancel

Don't we want this on release-1.15 instead?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nojnhuh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.04%. Comparing base (f738741) to head (3b791cf).
Report is 1 commits behind head on release-1.13.

Files Patch % Lines
controllers/azuremanagedcontrolplane_reconciler.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13    #4847      +/-   ##
================================================
- Coverage         62.04%   62.04%   -0.01%     
================================================
  Files               189      189              
  Lines             14971    14975       +4     
================================================
+ Hits               9289     9291       +2     
- Misses             5040     5042       +2     
  Partials            642      642              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willie-yao
Copy link
Contributor

Don't we want this on release-1.15 instead?

Whoops you're right!
/close

@k8s-ci-robot
Copy link
Contributor

@willie-yao: Closed this PR.

In response to this:

Don't we want this on release-1.15 instead?

Whoops you're right!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants