Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASOAPI: update docs #4802

Merged
merged 1 commit into from
May 6, 2024
Merged

ASOAPI: update docs #4802

merged 1 commit into from
May 6, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented May 3, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:

This updates the existing docs on the experimental ASOAPI from "this is a thing in-progress" to "this is a thing that's done."

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #4713

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

An experimental ASO-based API for AKS clusters is now available behind the `ASOAPI` feature flag and can be enabled through he `EXP_ASO_API` environment variable when installing CAPZ.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented May 3, 2024

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.77%. Comparing base (7e0ce0c) to head (2e74514).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4802      +/-   ##
==========================================
+ Coverage   62.73%   62.77%   +0.04%     
==========================================
  Files         199      199              
  Lines       16507    16569      +62     
==========================================
+ Hits        10356    10402      +46     
- Misses       5381     5389       +8     
- Partials      770      778       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented May 6, 2024

/hold for squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@nojnhuh nojnhuh mentioned this pull request May 6, 2024
4 tasks
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5cd63d654039192a02c96f0c68a0bf8971b8d665

@jackfrancis
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@nojnhuh
Copy link
Contributor Author

nojnhuh commented May 6, 2024

squashed!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6e2dbff into kubernetes-sigs:main May 6, 2024
18 checks passed
@nojnhuh nojnhuh linked an issue May 6, 2024 that may be closed by this pull request
@nojnhuh nojnhuh deleted the v2-docs branch May 6, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add experimental ASO-based API
4 participants