-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore manager bootstrap creds for subscription ID #4784
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4784 +/- ##
=======================================
Coverage 62.46% 62.46%
=======================================
Files 196 196
Lines 16180 16180
=======================================
Hits 10107 10107
Misses 5333 5333
Partials 740 740 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a65ca719f2986fe1d318dacfdfe48d85c2e12693
|
/assign @willie-yao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When we required AzureClusterIdentity starting in #3793, we removed the authentication environment variables from the CAPZ controller manager Pod, including
AZURE_SUBSCRIPTION_ID
. That value cannot be defined in an AzureClusterIdentity and is instead an optional field on AzureCluster and AzureManagedControlPlane. That "optional" qualifier requires that users are able to specify a subscription ID some other way. This PR restores theAZURE_SUBSCRIPTION_ID
variable for the controller manager Pod and can be set when CAPZ is installed the same way it could have been in CAPZ v1.10 and earlier.This is a near-term, backwards compatible fix to help us flesh out how we might want to modify the subscriptionID field longer-term in #4612.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4557
Special notes for your reviewer:
TODOs:
Release note: