-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicitly set default AZURE_SYNC_PERIOD for ASO #4764
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4764 +/- ##
==========================================
- Coverage 62.47% 62.38% -0.09%
==========================================
Files 195 196 +1
Lines 15902 16088 +186
==========================================
+ Hits 9934 10037 +103
- Misses 5268 5325 +57
- Partials 700 726 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1bf9862dc5d36f7c55403a87c71824baf44409d4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.13 |
/cherry-pick release-1.14 |
@nojnhuh: new pull request created: #4782 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nojnhuh: new pull request created: #4783 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
It looks like when we specify
AZURE_SYNC_PERIOD: ""
in the aso-controller-settings Secret, ASO is interpreting that as "do not resync" instead of "use the 1h default" like the docs describe and what we originally intended: https://azure.github.io/azure-service-operator/guide/aso-controller-settings-options/#azure_sync_period. This behavior might be a bug in ASO (Azure/azure-service-operator#3965), in which case this PR is a workaround. If this is intended behavior in ASO, then this PR represents a fix on our side.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: