-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump helm to v3.14.4 #4736
Bump helm to v3.14.4 #4736
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4736 +/- ##
=======================================
Coverage 62.44% 62.44%
=======================================
Files 195 195
Lines 15666 15666
=======================================
Hits 9782 9782
Misses 5198 5198
Partials 686 686 ☔ View full report in Codecov by Sentry. |
/assign @jackfrancis @mboersma @willie-yao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Having said that, I'm not sure where this copy of helm
is being used now that CAPZ uses CAAPH. Maybe this binary is used in make tilt-up
? I don't see anything in the Makefile
that actually uses it, just targets to install it.
The next CAAPH release will also have helm 3.14.4 vendored in, just FYI.
LGTM label has been added. Git tree hash: 189e8fa4fd31ccc26a97f755f75eb6900d7a3cac
|
@mboersma it is referenced here
So I think it is used in the E2Es. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.14 |
@mboersma: new pull request created: #4773 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.13 |
@mboersma: new pull request created: #4774 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumps helm to the latest version.
Special notes for your reviewer:
Release note: