Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump helm to v3.14.4 #4736

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Bump helm to v3.14.4 #4736

merged 1 commit into from
Apr 16, 2024

Conversation

damdo
Copy link
Member

@damdo damdo commented Apr 16, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Bumps helm to the latest version.

Special notes for your reviewer:

  • cherry-pick candidate, for bugfixing reasons

Release note:

Bump helm to v3.14.4

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.44%. Comparing base (43283e9) to head (016deed).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4736   +/-   ##
=======================================
  Coverage   62.44%   62.44%           
=======================================
  Files         195      195           
  Lines       15666    15666           
=======================================
  Hits         9782     9782           
  Misses       5198     5198           
  Partials      686      686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damdo
Copy link
Member Author

damdo commented Apr 16, 2024

/assign @jackfrancis @mboersma @willie-yao

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Having said that, I'm not sure where this copy of helm is being used now that CAPZ uses CAAPH. Maybe this binary is used in make tilt-up? I don't see anything in the Makefile that actually uses it, just targets to install it.

The next CAAPH release will also have helm 3.14.4 vendored in, just FYI.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 189e8fa4fd31ccc26a97f755f75eb6900d7a3cac

@damdo
Copy link
Member Author

damdo commented Apr 16, 2024

@mboersma it is referenced here

So I think it is used in the E2Es.

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 98971f6 into kubernetes-sigs:main Apr 16, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 16, 2024
@mboersma
Copy link
Contributor

/cherrypick release-1.14
/cherrypick release-1.13

@k8s-infra-cherrypick-robot

@mboersma: new pull request created: #4773

In response to this:

/cherrypick release-1.14
/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor

/cherrypick release-1.13

@k8s-infra-cherrypick-robot

@mboersma: new pull request created: #4774

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants