-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.14] Set nonzero default control plane node count in templates #4684
[release-1.14] Set nonzero default control plane node count in templates #4684
Conversation
- update worker machine count in the templates
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.14 #4684 +/- ##
================================================
+ Coverage 62.72% 62.73% +0.01%
================================================
Files 192 192
Lines 15644 15644
================================================
+ Hits 9813 9815 +2
+ Misses 5148 5146 -2
Partials 683 683 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 2a3cdc20fdabdc88e20f60ce306cc2b6e6bdb63e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #4660
/assign mboersma