Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release process #4642

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

dtzar
Copy link
Contributor

@dtzar dtzar commented Mar 12, 2024

Signed-off-by: David Tesar [email protected]

What type of PR is this?
Helps improve the flow of the release process steps including making it more clear how an outside contributor could help with this process if desired.

/kind documentation

What this PR does / why we need it:

Improve release process docs

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
@dtzar dtzar changed the title First pass at process enhancements Improve release process Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.73%. Comparing base (8cb4337) to head (1f2fd37).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4642   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files         192      192           
  Lines       15641    15641           
=======================================
  Hits         9812     9812           
  Misses       5146     5146           
  Partials      683      683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @dtzar, I think this does clarify the order of operations among other things. 👍🏻

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1583a7e208ff8f2f23ad5741f09921fa6d10605d

@dtzar
Copy link
Contributor Author

dtzar commented Mar 13, 2024

I would like some feedback from @mboersma and @jackfrancis on the post-release steps.

Specifically:

  1. Are there any steps there we think should be release-blocking?
  2. Is there a more optimal or combined order of operations?

@nawazkh
Copy link
Member

nawazkh commented Mar 14, 2024

/lgtm

@jackfrancis
Copy link
Contributor

/lgtm
/approve

I have some follow-up thoughts but this is a material improvement, let's land this, thanks @dtzar!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit ad6d0d9 into kubernetes-sigs:main Mar 18, 2024
18 checks passed
@jackfrancis jackfrancis added this to the v1.15 milestone Apr 12, 2024
@dtzar dtzar deleted the improvereldocs branch August 15, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants