-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.12] only consider spec in existing when reconciling ASO tags #4540
[release-1.12] only consider spec in existing when reconciling ASO tags #4540
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #4540 +/- ##
================================================
- Coverage 59.76% 59.75% -0.02%
================================================
Files 192 192
Lines 19316 19300 -16
================================================
- Hits 11544 11532 -12
+ Misses 7143 7139 -4
Partials 629 629 ☔ View full report in Codecov by Sentry. |
/lgtm |
LGTM label has been added. Git tree hash: 546facc894d5acd877ac8b134bb1816a6d2eb1a7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Manual cherry-pick of #4531:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: