-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.12] Remove deprecated kubelet credential provider flag #4437
[release-1.12] Remove deprecated kubelet credential provider flag #4437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 2bca822a9a276113aff6b313beea6a6c94781f33
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #4437 +/- ##
=============================================
Coverage 59.76% 59.76%
=============================================
Files 192 192
Lines 19316 19316
=============================================
Hits 11544 11544
Misses 7143 7143
Partials 629 629 ☔ View full report in Codecov by Sentry. |
Upgrade test failure is the same as #4422: /override pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1 |
@nojnhuh: Overrode contexts on behalf of nojnhuh: pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #4436
/assign CecileRobertMichon