Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] Remove deprecated kubelet credential provider flag #4437

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #4436

/assign CecileRobertMichon

Remove deprecated kubelet credential provider flag

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 6, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 6, 2024
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2bca822a9a276113aff6b313beea6a6c94781f33

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97720be) 59.76% compared to head (cce46c8) 59.76%.
Report is 1 commits behind head on release-1.12.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.12    #4437   +/-   ##
=============================================
  Coverage         59.76%   59.76%           
=============================================
  Files               192      192           
  Lines             19316    19316           
=============================================
  Hits              11544    11544           
  Misses             7143     7143           
  Partials            629      629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nojnhuh
Copy link
Contributor

nojnhuh commented Jan 6, 2024

Upgrade test failure is the same as #4422:

/override pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Overrode contexts on behalf of nojnhuh: pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1

In response to this:

Upgrade test failure is the same as #4422:

/override pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit d883996 into kubernetes-sigs:release-1.12 Jan 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants