-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
label Cluster for azuredisk-csi HelmChartProxy at E2E runtime #4334
label Cluster for azuredisk-csi HelmChartProxy at E2E runtime #4334
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4334 +/- ##
=======================================
Coverage 60.45% 60.45%
=======================================
Files 191 191
Lines 19195 19195
=======================================
Hits 11604 11604
Misses 6947 6947
Partials 644 644 ☔ View full report in Codecov by Sentry. |
068e140
to
0c8950d
Compare
Signed-off-by: Jack Francis <[email protected]>
0c8950d
to
26a8f5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/cherry-pick release-1.12
LGTM label has been added. Git tree hash: a44caafacbe88efa1d656f429075f4413f57784a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.12 |
@jackfrancis: new pull request created: #4337 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):This PR removes the in-template installation of azuredisk-csi drivers. Instead, we install the relevant HelmChartProxy as part of the cluster template, and then add the cluster label later during E2E if we want to install and test azuredisk-csi during our own test flow.
Fixes #
Special notes for your reviewer:
TODOs:
Release note: