Temporarily pin Flatcar version to v1.26.10 #4321
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
|
/test pull-cluster-api-provider-azure-e2e-optional |
test/e2e/helpers.go
Outdated
| } | ||
| // TODO: remove this once Flatcar image is patched https://github.com/kubernetes-sigs/image-builder/issues/1346 | ||
| // Temporarily pin to v1.26.10 | ||
| versions = append(versions, semver.MustParse("1.26.10")) |
There was a problem hiding this comment.
you can do this by changing https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/test/e2e/config/azure-dev.yaml#L173 so it bypasses this code completely
willie-yao
force-pushed
the
fix-flatcar-tmp
branch
from
a28b29c to
0d992d4
Compare
k8s-ci-robot
added
size/XS
willie-yao
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4321 +/- ##
==========================================
+ Coverage 60.17% 60.46% +0.28%
==========================================
Files 191 191
Lines 19200 19201 +1
==========================================
+ Hits 11554 11610 +56
+ Misses 7010 6947 -63
- Partials 636 644 +8 ☔ View full report in Codecov by Sentry. |
|
/test pull-cluster-api-provider-azure-e2e-optional |
|
/lgtm pending green optional test |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: f32a75faae8a8ad48d90ac4502eede13c1269682
|
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-provider-azure-e2e-optional |
|
@CecileRobertMichon The optional test passed and the only required test that failed is because of this known flake: #4264. Are we confident enough that the other failures are unrelated to slash hold cancel this? |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@willie-yao: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-1.12 |
|
@willie-yao: new pull request created: #4362 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.11 |
|
@willie-yao: new pull request created: #4363 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This test temporarily pins Flatcar version to v1.26.10 due to a known Flatcar issue: kubernetes-sigs/image-builder#1346
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes (temporarily) #4317
Special notes for your reviewer:
TODOs:
Release note: