-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "workaround ASO swallowing updates into ongoing operations" #4296
Revert "workaround ASO swallowing updates into ongoing operations" #4296
Conversation
This reverts commit 1a82f8c.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4296 +/- ##
==========================================
- Coverage 59.73% 59.72% -0.01%
==========================================
Files 192 192
Lines 19303 19299 -4
==========================================
- Hits 11531 11527 -4
Misses 7142 7142
Partials 630 630 ☔ View full report in Codecov by Sentry. |
/lgtm |
LGTM label has been added. Git tree hash: 3820055551683cf690879ec5b0ea604c1799b47e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR reverts #4158 which works around a bug in ASO now fixed in v2.4.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: