Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cloud provider azure Helm chart with CAAPH #4246

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Nov 9, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it: Install cloud provider azure Helm chart with CAAPH in e2e tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3736

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Install cloud provider azure Helm chart with CAAPH

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 9, 2023
@Jont828 Jont828 force-pushed the install-cloud-provider-azure-with-caaph branch 2 times, most recently from 4206fbe to 3c7c5c7 Compare November 10, 2023 02:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c1a8a2) 60.46% compared to head (c32e0c9) 60.45%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4246      +/-   ##
==========================================
- Coverage   60.46%   60.45%   -0.02%     
==========================================
  Files         191      191              
  Lines       19201    19195       -6     
==========================================
- Hits        11610    11604       -6     
  Misses       6947     6947              
  Partials      644      644              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jont828 Jont828 force-pushed the install-cloud-provider-azure-with-caaph branch from 3c7c5c7 to 795a753 Compare November 11, 2023 02:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023
@Jont828 Jont828 force-pushed the install-cloud-provider-azure-with-caaph branch from 795a753 to 3828aa0 Compare December 1, 2023 21:42
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2023

@Jont828: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apiversion-upgrade 4206fbe link false /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-conformance-with-ci-artifacts c32e0c9 link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts c32e0c9 link false /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts c32e0c9 link false /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
pull-cluster-api-provider-azure-windows-with-ci-artifacts c32e0c9 link false /test pull-cluster-api-provider-azure-windows-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-custom-builds c32e0c9 link false /test pull-cluster-api-provider-azure-conformance-custom-builds
pull-cluster-api-provider-azure-windows-custom-builds c32e0c9 link false /test pull-cluster-api-provider-azure-windows-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis
Copy link
Contributor

@Jont828 I think we want to install with a label assignment during E2E runtime rather than adding the label in the template itself. Like we ended up doing here for azuredisk-csi:

Basically some of these templates may be used by downstream cloud-provider-azure tests where they want to install their own opinionated installation of cloud-provider-azure (for example from bits built at runtime against a cloud-provider-azure dev branch).

cc @CecileRobertMichon

@Jont828
Copy link
Contributor Author

Jont828 commented Dec 11, 2023

/assign @CecileRobertMichon

@Jont828
Copy link
Contributor Author

Jont828 commented Dec 12, 2023

@jackfrancis I already set up something similar since it's configured based on an environment variable

@CecileRobertMichon
Copy link
Contributor

/close

will open a new PR when ready

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closed this PR.

In response to this:

/close

will open a new PR when ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use CAAPH to install Helm charts in e2e tests
4 participants