-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install cloud provider azure Helm chart with CAAPH #4246
Install cloud provider azure Helm chart with CAAPH #4246
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4206fbe
to
3c7c5c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
==========================================
- Coverage 60.46% 60.45% -0.02%
==========================================
Files 191 191
Lines 19201 19195 -6
==========================================
- Hits 11610 11604 -6
Misses 6947 6947
Partials 644 644 ☔ View full report in Codecov by Sentry. |
3c7c5c7
to
795a753
Compare
795a753
to
3828aa0
Compare
@Jont828: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Jont828 I think we want to install with a label assignment during E2E runtime rather than adding the label in the template itself. Like we ended up doing here for azuredisk-csi: Basically some of these templates may be used by downstream cloud-provider-azure tests where they want to install their own opinionated installation of cloud-provider-azure (for example from bits built at runtime against a cloud-provider-azure dev branch). |
/assign @CecileRobertMichon |
@jackfrancis I already set up something similar since it's configured based on an environment variable |
/close will open a new PR when ready |
@CecileRobertMichon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it: Install cloud provider azure Helm chart with CAAPH in e2e tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3736
Special notes for your reviewer:
TODOs:
Release note: