Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Set correct fqdn on private cluster #4241

Merged

Conversation

mihaiandreiratoiu
Copy link
Contributor

@mihaiandreiratoiu mihaiandreiratoiu commented Nov 7, 2023

What type of PR is this?
Adapted from #4225
/kind bug

What this PR does / why we need it:
On private cluster with the managedcontrolplane

  • EnablePrivateCluster: true
  • EnablePrivateClusterPublicFQDN: false
    The fqdn property is not available. The cluster defaults to the privateFQDN
    The Cluster resource remains in provisioning state due to the capz error
spec.controlPlaneEndpoint.host: Required value" "AzureManagedCluster"

Special notes for your reviewer:

  • cherry-pick candidate
  • to cherry-pick into release-1.11

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

 Fix: Set correct host on private cluster with public fqdn disabled

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mihaiandreiratoiu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2023
@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 7, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f47fd94) 54.36% compared to head (b18aaf7) 54.38%.
Report is 1 commits behind head on release-1.10.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #4241      +/-   ##
================================================
+ Coverage         54.36%   54.38%   +0.01%     
================================================
  Files               186      186              
  Lines             18898    18906       +8     
================================================
+ Hits              10274    10282       +8     
  Misses             8069     8069              
  Partials            555      555              
Files Coverage Δ
azure/services/managedclusters/managedclusters.go 80.28% <100.00%> (+2.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a2a684e693be87ff2f08e3c26a75aa3f8945b89

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm++

Thanks @mihaiandreiratoiu!

@nojnhuh
Copy link
Contributor

nojnhuh commented Nov 7, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0740df0 into kubernetes-sigs:release-1.10 Nov 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants