-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] Set correct fqdn on private cluster #4241
[release-1.10] Set correct fqdn on private cluster #4241
Conversation
Hi @mihaiandreiratoiu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
09bb886
to
b18aaf7
Compare
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #4241 +/- ##
================================================
+ Coverage 54.36% 54.38% +0.01%
================================================
Files 186 186
Lines 18898 18906 +8
================================================
+ Hits 10274 10282 +8
Misses 8069 8069
Partials 555 555
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 8a2a684e693be87ff2f08e3c26a75aa3f8945b89
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm++
Thanks @mihaiandreiratoiu!
/retest |
What type of PR is this?
Adapted from #4225
/kind bug
What this PR does / why we need it:
On private cluster with the managedcontrolplane
The fqdn property is not available. The cluster defaults to the
privateFQDN
The Cluster resource remains in provisioning state due to the capz error
Special notes for your reviewer:
TODOs:
Release note: