[release-1.11] Add support for OOT cred provider in ci templates #4232
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XXL
| @@ -1,1179 +0,0 @@ | |||
| apiVersion: cluster.x-k8s.io/v1beta1 | |||
There was a problem hiding this comment.
this template is not tracked by any test flavor and should have been removed as part of 8929290, it's already removed from the main branch
|
@CecileRobertMichon: GitHub didn't allow me to assign the following users: mainred. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CecileRobertMichon
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #4232 +/- ##
================================================
- Coverage 56.69% 56.68% -0.02%
================================================
Files 187 187
Lines 19214 19214
================================================
- Hits 10893 10891 -2
- Misses 7691 7693 +2
Partials 630 630 ☔ View full report in Codecov by Sentry. |
prow flake /retest |
| echo "Use OOT credential provider" | ||
| mkdir C:\var\lib\kubelet\credential-provider | ||
| curl.exe --retry 10 --retry-delay 5 -L "https://${AZURE_STORAGE_ACCOUNT}.blob.core.windows.net/${AZURE_BLOB_CONTAINER_NAME}/${IMAGE_TAG_ACR_CREDENTIAL_PROVIDER}/azure-acr-credential-provider.exe" --output C:\var\lib\kubelet\credential-provider\acr-credential-provider.exe | ||
| cp C:\var\lib\kubelet\credential-provider\acr-credential-provider.exe C:\var\lib\kubelet\credential-provider\acr-credential-provider |
There was a problem hiding this comment.
This is odd. I assume it's because something else needs to refer to it without the .exe extension?
There was a problem hiding this comment.
There's a bug in k/k but so far my fix PR hasn't been merged.
kubernetes/kubernetes#120291
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 74951dd692e5b2cf37d85fe7bac8603b57b91b3d
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Addresses part of #4110
Special notes for your reviewer:
TODOs:
Release note: