-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait for ASO deployment in make create-management-cluster #4217
Conversation
/retest "received unexpected HTTP status: 503 Service Unavailable" docker down? |
/cherry-pick release-1.11 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've seen a few random errors like that lately locally, nothing persistent though. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4217 +/- ##
==========================================
+ Coverage 58.31% 58.33% +0.01%
==========================================
Files 187 187
Lines 19231 19240 +9
==========================================
+ Hits 11214 11223 +9
Misses 7387 7387
Partials 630 630 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: d3dfc8b92fb1d72d713505dad565e425d8878ae0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nojnhuh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@nojnhuh: new pull request created: #4219 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nojnhuh: new pull request created: #4220 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR updates the
make create-management-cluster
target invoked by ci-entrypoint.sh to wait for the ASO Deployment in addition to the CAPZ Deployment to prevent a yet-to-be-seen issue where ASO resources are created before it is ready.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):I'm almost certain the root cause is unrelated, but this may improve #4215
Special notes for your reviewer:
TODOs:
Release note: