Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnableEncryptionAtHost in ManagedMachinePool #4181

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Add EnableEncryptionAtHost in ManagedMachinePool #4181

merged 1 commit into from
Nov 1, 2023

Conversation

mihaiandreiratoiu
Copy link
Contributor

@mihaiandreiratoiu mihaiandreiratoiu commented Oct 26, 2023 •
edited
Loading

What this PR does / why we need it:

  • Add EnableEncryptionAtHost flag in ManagedMachinePool

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

 - Add EnableEncryptionAtHost in ManagedMachinePool

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 26, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 26, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mihaiandreiratoiu / name: Mihai Ratoiu (72a7afe)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mihaiandreiratoiu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mihaiandreiratoiu mihaiandreiratoiu changed the title Add EnableEncryptionAtHost in ManageMachinePool Add EnableEncryptionAtHost in ManagedMachinePool Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 26, 2023
@dtzar
Copy link
Contributor

dtzar commented Oct 26, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2023
@CecileRobertMichon CecileRobertMichon self-assigned this Oct 26, 2023
@CecileRobertMichon
Copy link
Contributor

@mihaiandreiratoiu please take a look at failing tests

@mihaiandreiratoiu
Copy link
Contributor Author

/retest

@mihaiandreiratoiu
Copy link
Contributor Author

/retest

@mihaiandreiratoiu
Copy link
Contributor Author

/retest

@mihaiandreiratoiu
Copy link
Contributor Author

/retest

CecileRobertMichon
CecileRobertMichon reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @nojnhuh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa345ced61c45226c0f61c56dfd9f254afbff0e6

@dtzar
Copy link
Contributor

dtzar commented Oct 31, 2023

@nojnhuh - looks like codecov just failed to upload results, so just needs an approval to merge?

@CecileRobertMichon
Copy link
Contributor

@dtzar I just triggered codecov

I assigned @nojnhuh to this one because it conflicts with #3529 so want to make sure he has a chance to review/integrate with his PR

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 31, 2023

At first glance I don't see anything that conflicts with #4069 more than any other feature, so I'm pretty confident this won't need changes to accommodate ASO but I'll review this when I get the chance.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a53ffb) 57.87% compared to head (72a7afe) 58.33%.
Report is 40 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4181      +/-   ##
==========================================
+ Coverage   57.87%   58.33%   +0.45%     
==========================================
  Files         187      187              
  Lines       19216    19240      +24     
==========================================
+ Hits        11122    11223     +101     
+ Misses       7466     7387      -79     
- Partials      628      630       +2
Files Coverage Δ
api/v1beta1/azuremanagedmachinepool_types.go 20.00% <ø> (ø)
api/v1beta1/azuremanagedmachinepool_webhook.go 81.81% <100.00%> (+0.25%) ⬆️
azure/converters/managedagentpool.go 91.66% <100.00%> (+0.23%) ⬆️
azure/scope/managedmachinepool.go 43.91% <100.00%> (+0.29%) ⬆️
azure/services/agentpools/spec.go 64.06% <100.00%> (+0.15%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2023
@mihaiandreiratoiu @nojnhuh
Add EnableEncryptionAtHost in ManageMachinePool
72a7afe 
Update api/v1beta1/azuremanagedmachinepool_types.go

Co-authored-by: Jon Huhn <[email protected]>
@mihaiandreiratoiu
Copy link
Contributor Author

/retest

nojnhuh
nojnhuh reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you @mihaiandreiratoiu!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dc4c8bc038838defce514c3b8324f9a4551fa19a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9d2157f into kubernetes-sigs:main Nov 1, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@Jont828 Jont828 Awaiting requested review from Jont828

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@CecileRobertMichon CecileRobertMichon

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
5 participants
@mihaiandreiratoiu @k8s-ci-robot @dtzar @CecileRobertMichon @nojnhuh