fix for add-on profile update for AKS clusters #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4176 +/- ##
==========================================
+ Coverage 57.86% 57.96% +0.09%
==========================================
Files 187 187
Lines 19216 19253 +37
==========================================
+ Hits 11120 11160 +40
+ Misses 7468 7463 -5
- Partials 628 630 +2
☔ View full report in Codecov by Sentry. |
LochanRn
force-pushed
the
fix-addon-profile-upgdate
branch
2 times, most recently
from
361be05 to
005e575
Compare
mboersma
reviewed
Oct 25, 2023
nojnhuh
reviewed
Oct 25, 2023
LochanRn
force-pushed
the
fix-addon-profile-upgdate
branch
from
005e575 to
23ab146
Compare
LochanRn
force-pushed
the
fix-addon-profile-upgdate
branch
from
23ab146 to
d71965d
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a16716174cd6247d5b555464b790965ece033f2b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Allows upgrade/update of addon profiles on a running AKS cluster
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4175
Special notes for your reviewer:
TODOs:
Release note: