-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add missing unit test for covering azure.ParseResourceID() #4165
test: Add missing unit test for covering azure.ParseResourceID() #4165
Conversation
Hi @chandankumar4. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -74,29 +71,6 @@ func (ac *AzureClient) Get(ctx context.Context, spec azure.ResourceSpecGetter) ( | |||
return resp.VirtualMachine, nil | |||
} | |||
|
|||
// GetByID retrieves information about the model or instance view of a virtual machine. | |||
func (ac *AzureClient) GetByID(ctx context.Context, resourceID string) (armcompute.VirtualMachine, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is not used anywhere
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4165 +/- ##
==========================================
+ Coverage 57.87% 58.17% +0.30%
==========================================
Files 187 187
Lines 19212 19191 -21
==========================================
+ Hits 11118 11164 +46
+ Misses 7466 7399 -67
Partials 628 628
☔ View full report in Codecov by Sentry. |
Signed-off-by: chandankumar4 <[email protected]>
f4e0ef9
to
0b2b6b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 2a947963978a4371f54c1b5cc72105e1c6d34731
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add the missing unit test case for covering azure.ParseResourceID()
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3622
Special notes for your reviewer:
TODOs:
Release note: