✨ Add webhook-cert-dir flag #4151
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4151 +/- ##
==========================================
+ Coverage 57.83% 57.87% +0.03%
==========================================
Files 187 187
Lines 19197 19212 +15
==========================================
+ Hits 11103 11118 +15
Misses 7466 7466
Partials 628 628 ☔ View full report in Codecov by Sentry. |
main.go
Outdated
| @@ -224,6 +225,9 @@ func InitFlags(fs *pflag.FlagSet) { | |||
| "Webhook Server port, disabled by default. When enabled, the manager will only work as webhook server, no reconcilers are installed.", | |||
| ) | |||
|
|
|||
| fs.StringVar(&webhookCertDir, "webhook-cert-dir", "", | |||
There was a problem hiding this comment.
In CAPI, this flag has a default value. Does CAPZ need to do the same here?
"only used when webhook-port is specified."
Does this mean the value is ignored unless --webhook-port was overridden? The code just passes both values through regardless.
There was a problem hiding this comment.
I copied the flag, but dropped the default because I noticed it was already set in the Deployment yaml; can add it back if we prefer.
The comment is a bit confusing, I agree.
There was a problem hiding this comment.
it was already set in the Deployment yaml;
Ah, I missed that. Thanks for updating, I think this is more clear.
Adds the --webhook-cert-dir flag to customize where the certificates are stored, and passes it to the controller-runtime webhook handler. Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
webhook-cert-dir
branch
from
d6bbad6 to
b48d686
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6b7833142ef9437947c8d93c849f40aed9f1c95d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the --webhook-cert-dir flag to customize where the certificates are stored, and passes it to the controller-runtime webhook handler.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: