Fix AKS reconciliation of taints

[willie-yao]

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixes a bug where AzureManagedMachinePools with Spot instances endlessly reconciles node taints.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3976

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (337e5d5) 56.80% compared to head (fc44a4e) 56.77%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4066      +/-   ##
==========================================
- Coverage   56.80%   56.77%   -0.03%     
==========================================
  Files         188      188              
  Lines       19150    19187      +37     
==========================================
+ Hits        10878    10894      +16     
- Misses       7644     7665      +21     
  Partials      628      628              

Files	Coverage Δ
azure/services/agentpools/spec.go	63.11% <100.00%> (+2.82%)	⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[willie-yao]

/assign @nojnhuh

[nojnhuh]

Thank you!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e206254ffa485faca1e348feca621a897c126f8b

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nojnhuh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nojnhuh]

/cherry-pick release-1.11

/cherry-pick release-1.10
^ @willie-yao This will probably fail because SDK v2, but would be good to include there.

[k8s-infra-cherrypick-robot]

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

/cherry-pick release-1.10
^ @willie-yao This will probably fail because SDK v2, but would be good to include there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@nojnhuh: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

In response to this:

/cherry-pick release-1.11

/cherry-pick release-1.10
^ @willie-yao This will probably fail because SDK v2, but would be good to include there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@nojnhuh: #4066 failed to apply on top of branch "release-1.10":

Applying: Fix AKS reconciliation of taints
Using index info to reconstruct a base tree...
M	azure/services/agentpools/spec.go
M	azure/services/agentpools/spec_test.go
Falling back to patching base and 3-way merge...
Auto-merging azure/services/agentpools/spec_test.go
Auto-merging azure/services/agentpools/spec.go
CONFLICT (content): Merge conflict in azure/services/agentpools/spec.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix AKS reconciliation of taints
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

/cherry-pick release-1.10
^ @willie-yao This will probably fail because SDK v2, but would be good to include there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nojnhuh]

@willie-yao Could you please backport this to 1.10?

[willie-yao]

/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@willie-yao: #4066 failed to apply on top of branch "release-1.10":

Applying: Fix AKS reconciliation of taints
Using index info to reconstruct a base tree...
M	azure/services/agentpools/spec.go
M	azure/services/agentpools/spec_test.go
Falling back to patching base and 3-way merge...
Auto-merging azure/services/agentpools/spec_test.go
Auto-merging azure/services/agentpools/spec.go
CONFLICT (content): Merge conflict in azure/services/agentpools/spec.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix AKS reconciliation of taints
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[willie-yao]

/cherry-pick release-1.11

[k8s-infra-cherrypick-robot]

@willie-yao: new pull request created: #4140

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.