update envtest k8s to 1.27 #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4028 +/- ##
=======================================
Coverage 56.57% 56.57%
=======================================
Files 187 187
Lines 19130 19130
=======================================
Hits 10823 10823
Misses 7676 7676
Partials 631 631
☔ View full report in Codecov by Sentry. |
mboersma
reviewed
Sep 22, 2023
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6e64356f1345ba253e9e821f796e4adc9fd0a6c1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it: This PR updates the version of Kubernetes components used by envtest to 1.27 to match the rest of CAPZ's Kubernetes dependencies.
Only updating the version causes the tests to time out while stopping the API server, so this PR also includes a fix for that which cancels the
context.Contextused to start the controller manager right before the control plane is stopped.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3420
Special notes for your reviewer:
TODOs:
Release note: