Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Tests for all Parameters() of the service libraries that don't have them. #4021

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add Unit Tests for all Parameters() of the service libraries that don't have them. #4021

merged 1 commit into from
Oct 6, 2023

Conversation

chandankumar4
Copy link
Contributor

@chandankumar4 chandankumar4 commented Sep 21, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR add the Unit Test cases for all Parameters() of the service libraries that don't have them currently.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2946

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @chandankumar4!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @chandankumar4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chandankumar4
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 21, 2023
@chandankumar4 chandankumar4 changed the title [WIP] Add Unit Tests for all Parameters() of the service libraries that don't currently have them. [WIP] Add Unit Tests for all Parameters() of the service libraries that don't have them. Sep 21, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 21, 2023
@chandankumar4 chandankumar4 changed the title [WIP] Add Unit Tests for all Parameters() of the service libraries that don't have them. Add Unit Tests for all Parameters() of the service libraries that don't have them. Sep 25, 2023
@chandankumar4 chandankumar4 marked this pull request as ready for review September 25, 2023 06:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2023
@CecileRobertMichon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2023
@chandankumar4
Copy link
Contributor Author

/retest

@chandankumar4
Copy link
Contributor Author

/retest

willie-yao
willie-yao approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your work on this! Apologies for the late review.

Note: Can you please squash your commits?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b75e440af4dd69318a6d2716b85e1a7d66d14db

@CecileRobertMichon
Copy link
Contributor

/assign @sonasingh46

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (00fb137) 56.59% compared to head (6f43cfb) 57.37%.
Report is 76 commits behind head on main.

❗ Current head 6f43cfb differs from pull request most recent head 30bf98a. Consider uploading reports for the commit 30bf98a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
+ Coverage   56.59%   57.37%   +0.77%     
==========================================
  Files         187      187              
  Lines       19124    19130       +6     
==========================================
+ Hits        10823    10975     +152     
+ Misses       7671     7523     -148     
- Partials      630      632       +2

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chandankumar4
Add Unit test case for prarmeters methods
30bf98a 
Add unit test case for bastionhosts parameters method
Add unit test case for natgateways parameters methods
Add unit test cases for roleassignment and routetables
Add unit test cases for virtual-network and vnet-peerings
@chandankumar4 chandankumar4 force-pushed the parameters-unit-tests branch from 6f43cfb to 30bf98a Compare October 6, 2023 06:33
@sonasingh46
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sonasingh46

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5aba3bb into kubernetes-sigs:main Oct 6, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 6, 2023
@chandankumar4 chandankumar4 deleted the parameters-unit-tests branch October 6, 2023 08:42
@chandankumar4 chandankumar4 mentioned this pull request Oct 3, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

Assignees

@sonasingh46 sonasingh46

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Backfill Parameters() Unit Tests for all of the service libraries that don't currently have them
5 participants
@chandankumar4 @k8s-ci-robot @CecileRobertMichon @sonasingh46 @willie-yao