Arm64 should be upper cased and a const

[CecileRobertMichon]

What type of PR is this?

/kind bug

What this PR does / why we need it: Azure VM SKU cpuArchitectureType property is Arm64, not arm64. Note: I tried to find a const in the Azure SDK to use directly but couldn't find one. @mboersma to the rescue!

Special thanks to @arsiesys for finding the issue

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4016

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

fix arm64 extension selection

[CecileRobertMichon]

/cherry-pick release-1.11
/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

/assign @mboersma

[mboersma]

I tried to find a const in the Azure SDK to use directly

There is armcompute.ArchitectureTypesArm64: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5#ArchitectureTypes

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e333aa) 56.58% compared to head (b653f89) 56.58%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4018   +/-   ##
=======================================
  Coverage   56.58%   56.58%           
=======================================
  Files         187      187           
  Lines       19126    19126           
=======================================
  Hits        10823    10823           
  Misses       7672     7672           
  Partials      631      631           

Files Changed	Coverage Δ
azure/defaults.go	48.79% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[CecileRobertMichon]

Thank you @mboersma that's much better

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: bd669ffb87c89eec1b1e9b047d42989b989811d7

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: #4018 failed to apply on top of branch "release-1.10":

Applying: Arm64 should be upper cased and a const
Using index info to reconstruct a base tree...
M	azure/defaults.go
M	azure/defaults_test.go
Falling back to patching base and 3-way merge...
Auto-merging azure/defaults_test.go
CONFLICT (content): Merge conflict in azure/defaults_test.go
Auto-merging azure/defaults.go
CONFLICT (content): Merge conflict in azure/defaults.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Arm64 should be upper cased and a const
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: new pull request created: #4020

In response to this:

/cherry-pick release-1.11
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mboersma]

#4018 failed to apply on top of branch "release-1.10":

There is a compute.ArchitectureTypesArm64 constant we could use for the release-1.10 branch (Azure SDK for Go v1): https://pkg.go.dev/github.com/Azure/[email protected]+incompatible/services/compute/mgmt/2021-11-01/compute#ArchitectureTypes

[nojnhuh]

@CecileRobertMichon Are we still looking to backport this to release-1.10?

[CecileRobertMichon]

@nojnhuh yes thanks for the nudge, I'll open a manual cherry-pick PR shortly

I take that back, the PR that added the constant was only merged in 1.11 so no need to cherry-pick to 1.10 1fcf681