-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Workload Identity doc for ASO #4017
Conversation
/cherry-pick release-1.11 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4017 +/- ##
=======================================
Coverage 56.58% 56.58%
=======================================
Files 187 187
Lines 19126 19126
=======================================
Hits 10823 10823
Misses 7672 7672
Partials 631 631 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
should we cherry-pick this to 1.11 so it's in the book? looks like you already did
/assign @sonasingh46
/lgtm |
LGTM label has been added. Git tree hash: 215434179c3f1037b49dbaf0bb30157d92393390
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nojnhuh: new pull request created: #4024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Authenticating with WorkloadIdentity requires federated credentials for both the CAPZ ServiceAccount and the ASO ServiceAccount. This PR updates the docs to reflect that.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #3851, #3770
Special notes for your reviewer:
TODOs:
Release note: