Set cloud provider config to have shorter cache ttl #3977
Conversation
Signed-off-by: Zhecheng Li <[email protected]>
|
@lzhecheng: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3977 +/- ##
=======================================
Coverage 56.15% 56.15%
=======================================
Files 191 191
Lines 19417 19417
=======================================
Hits 10903 10903
Misses 7880 7880
Partials 634 634 ☔ View full report in Codecov by Sentry. |
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
| @@ -25,12 +25,16 @@ source "${REPO_ROOT}/hack/common-vars.sh" | |||
|
|
|||
| make --directory="${REPO_ROOT}" "${KUBECTL##*/}" | |||
|
|
|||
| # Test cloud provider config with shorter cache ttl | |||
There was a problem hiding this comment.
Test suggests we don't know yet if the shorter cache ttl will work. @lzhecheng do we want to merge this change anyway? lgtm overall.
There was a problem hiding this comment.
Yes.
The purpose is to shorten the period of time "before node shutdown taint and node out-of-service taint are added" for feature non-graceful-node-shutdown. PR.
Shorter cache ttl needs testing before applied in AKS.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: eab27a351f5a7acd6bebed464875c29dccf0fe17
|
|
/assign @CecileRobertMichon |
|
/cherrypick release-1.10 |
|
@lzhecheng: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
@lzhecheng: new pull request created: #4001 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind testing
What this PR does / why we need it:
Set cloud provider config to have shorter cache ttl
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Related: kubernetes-sigs/cloud-provider-azure#4594
Special notes for your reviewer:
TODOs:
Release note: