update loadbalancers service to use Azure SDK v2

[nawazkh]

What type of PR is this?
/kind feature

What this PR does / why we need it:

• This PR updates load balancers service to sdkv2.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3917

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Update loadbalancers service to use Azure SDK v2

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Patch coverage: 54.96% and project coverage change: +0.08% 🎉

Comparison is base (b082981) 56.26% compared to head (d89c16c) 56.34%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3969      +/-   ##
==========================================
+ Coverage   56.26%   56.34%   +0.08%     
==========================================
  Files         190      190              
  Lines       19447    19420      -27     
==========================================
+ Hits        10941    10942       +1     
+ Misses       7877     7848      -29     
- Partials      629      630       +1     

Files Changed	Coverage Δ
azure/services/loadbalancers/client.go	0.00% <0.00%> (ø)
azure/services/loadbalancers/loadbalancers.go	73.07% <0.00%> (-6.09%)	⬇️
controllers/azurecluster_reconciler.go	57.71% <40.00%> (-0.91%)	⬇️
azure/services/loadbalancers/spec.go	92.59% <98.55%> (ø)
azure/converters/loadbalancers.go	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nawazkh]

Expected complaints from apidiff

sigs.k8s.io/cluster-api-provider-azure/azure/services/loadbalancers
Incompatible changes:
  - New: changed from func(LBScope) *Service to func(LBScope) (*Service, error)

sigs.k8s.io/cluster-api-provider-azure/azure/converters
Incompatible changes:
  - SKUtoSDK: changed from func(sigs.k8s.io/cluster-api-provider-azure/api/v1beta1.SKU) github.com/Azure/azure-sdk-for-go/services/network/mgmt/2021-08-01/network.LoadBalancerSkuName to func(sigs.k8s.io/cluster-api-provider-azure/api/v1beta1.SKU) github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4.LoadBalancerSKUName

[nojnhuh]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7a8c34896336f741c70a3a44842e71a2530c13bf

[mboersma]

lgtm, I just had one change to a comment for consistency with the other services.

[k8s-ci-robot]

@nawazkh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	d89c16c	link	false	/test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a8c2ced3cb46257e60d77177e4d84cb1664deee1

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment