-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] ignore AKS user-assigned ClientID/PrincipalID in diff #3963
[release-1.10] ignore AKS user-assigned ClientID/PrincipalID in diff #3963
Conversation
/lgtm |
LGTM label has been added. Git tree hash: b5567b13055cc2329e0209885165f7e2e348e709
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #3963 +/- ##
================================================
+ Coverage 54.26% 54.27% +0.01%
================================================
Files 186 186
Lines 18855 18861 +6
================================================
+ Hits 10231 10237 +6
Misses 8069 8069
Partials 555 555
☔ View full report in Codecov by Sentry. |
Go modules 503: |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Manual cherry-pick of #3962:
This fixes a bug causing an endless reconciliation of AzureManagedControlPlane with
spec.identity.type
set toUserAssigned
because of a continuous diff like this:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: