Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Cluster -> AzureManagedMachinePool mapper #3809

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 7, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

This PR fixes the mapper used to set up the AzureManagedMachinePoolController to correctly map Cluster events to a particular AzureManagedMachinePool. e.g. Unpausing a Cluster was not triggering a reconciliation for AzureManagedMachinePools associated with that Cluster.

I think what was there before was a plain copy-paste from the AzureManagedControlPlane controller. It has been updated to more closely match how the AzureMachinePool controller is set up.

Related: #3699

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Fixed a bug causing Cluster events not to re-reconcile AzureManagedMachinePools

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2023
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 7, 2023

/cherry-pick release-1.9
/cherry-pick release-1.10

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.01% ⚠️

Comparison is base (8893daa) 54.77% compared to head (53204c9) 54.76%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3809      +/-   ##
==========================================
- Coverage   54.77%   54.76%   -0.01%     
==========================================
  Files         187      187              
  Lines       19098    19102       +4     
==========================================
+ Hits        10460    10461       +1     
- Misses       8070     8072       +2     
- Partials      568      569       +1     
Files Changed Coverage Δ
controllers/azuremanagedmachinepool_controller.go 52.91% <40.00%> (-0.56%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jont828 Jont828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1e9f2c896c19b2666ec527e4bcb542915e7d9fb9

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7ae01bb into kubernetes-sigs:main Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Aug 8, 2023
@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #3815

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #3816

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants