Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused multi-tenancy creds #3797

Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Aug 3, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it: Noticed these leftover creds are no longer used anywhere and were leftover from an old test that got removed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 3, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2023
Copy link
Contributor Author

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecileRobertMichon
Copy link
Contributor Author

/cherry-pick release 1.10
/cherry-pick release 1.9

/test pull-cluster-api-provider-azure-e2e-optional

@k8s-infra-cherrypick-robot

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release 1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release 1.10
/cherry-pick release 1.9

/test pull-cluster-api-provider-azure-e2e-optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (7e8c80b) 54.37% compared to head (d04bfa1) 54.38%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3797      +/-   ##
==========================================
+ Coverage   54.37%   54.38%   +0.01%     
==========================================
  Files         187      187              
  Lines       19015    19015              
==========================================
+ Hits        10340    10342       +2     
+ Misses       8117     8115       -2     
  Partials      558      558              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2684454273493166ac977072f335c81b576fd0d3

@CecileRobertMichon
Copy link
Contributor Author

/retest

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@mboersma
Copy link
Contributor

mboersma commented Aug 4, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 76bdae4 into kubernetes-sigs:main Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Aug 4, 2023
@k8s-infra-cherrypick-robot

@CecileRobertMichon: cannot checkout release 1.10: error checking out release 1.10: exit status 1. output: error: pathspec 'release 1.10' did not match any file(s) known to git

In response to this:

/cherry-pick release 1.10
/cherry-pick release 1.9

/test pull-cluster-api-provider-azure-e2e-optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@CecileRobertMichon: cannot checkout release 1.9: error checking out release 1.9: exit status 1. output: error: pathspec 'release 1.9' did not match any file(s) known to git

In response to this:

/cherry-pick release 1.10
/cherry-pick release 1.9

/test pull-cluster-api-provider-azure-e2e-optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor

mboersma commented Aug 4, 2023

/cherry-pick release-1.10
/cherry-pick release-1.9

@k8s-infra-cherrypick-robot

@mboersma: new pull request created: #3801

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor

mboersma commented Aug 4, 2023

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot

@mboersma: new pull request created: #3802

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor Author

cannot checkout release 1.10

whoops, thank you @mboersma!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants