✨Add liveness and readiness probes

[cpanato]

What this PR does / why we need it:
Similar was made here kubernetes-sigs/cluster-api-provider-aws#1487 and kubernetes-sigs/cluster-api#2156
Adding the liveness and readiness probes for cluster-api-providere-azure

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

- liveness and readiness probes added

/cc @vincepri

[k8s-ci-robot]

Welcome @cpanato!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @cpanato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nader-ziada]

/ok-to-test

[cpanato]

It is failing due the modules are outdated, do I need to update that here or this will be part of another PR?

[nader-ziada]

which modules are needed? I would say you probably need to update them here so this PR is not blocked

[CecileRobertMichon]

let's hold this one until the v1alpha3 PR is in since it's the highest priority right now

/hold

[CecileRobertMichon]

@cpanato feel free to update the modules in this PR. Which ones need to be bumped?

[cpanato]

@CecileRobertMichon I don't need to add any new modules, but when I ran make modules it update the ones I've committed.

[cpanato]

@CecileRobertMichon yes, I was experimenting here :)
I will open another PR because looks like we need that here

[cpanato]

@CecileRobertMichon this PR is ready

[CecileRobertMichon]

@cpanato there's a typo in the commit message, can you please fix it?

[CecileRobertMichon]

/approve
/hold until the commit message is fixed

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cpanato]

@CecileRobertMichon done

[CecileRobertMichon]

/hold cancel
/lgtm