-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated wasm docs to include wasm workers server #3728
Conversation
Signed-off-by: Darwin Boersma <[email protected]>
Welcome @ogghead! |
Hi @ogghead. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
==========================================
- Coverage 54.05% 54.04% -0.02%
==========================================
Files 186 186
Lines 18833 18833
==========================================
- Hits 10181 10179 -2
- Misses 8105 8107 +2
Partials 547 547 ☔ View full report in Codecov by Sentry. |
Thank you for the changes @ogghead . The changes look good to me, however I was not able to get any response on Here is my workload cluster running Azure CNI v1
and output of
and
I am not sure if it is related to your PR. But if you have any clue, I would love to know more :) |
@nawazkh I think this is due to our Azure development subscriptions being locked down for security reasons: you can't by default hit port 80 (or do SSH). @ogghead was able to follow the docs as written, but when I've tested the Wasm shims in CAPZ, I've had to hit the app endpoints from within the cluster to avoid our external port blocking. I tested this again after kubernetes-sigs/image-builder#1220 landed and was able to verify all three Wasm runtimes that way, so I think these docs are ok. |
^ Makes sense. Thanks for the context! |
Looks good to me! |
LGTM label has been added. Git tree hash: 1b6a62521197496d4852a5685c79a52b232ec97d
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):N/A
Special notes for your reviewer:
Follows up on Updated wasm-shims to 0.7.0, added support for wws image-builder#1220
cherry-pick candidate
TODOs:
Release note: