-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase AKS reconcile timeout #3657
Increase AKS reconcile timeout #3657
Conversation
/cherry-pick release-1.9 |
@willie-yao: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 4b6fe6ea0916b06e3cb151fdb5598a574a72de2c
|
I think the cherry-pick bot only likes one of these in a comment at a time :/ /cherry-pick release-1.8 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3657 +/- ##
=======================================
Coverage 53.74% 53.74%
=======================================
Files 185 185
Lines 18595 18595
=======================================
Hits 9994 9994
Misses 8059 8059
Partials 542 542
☔ View full report in Codecov by Sentry. |
/test pull-cluster-api-provider-azure-e2e-aks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I think the cherry-pick bot only likes one of these in a comment at a time
@nojnhuh I've done two /cherry-pick
commands before and it's worked. I think the bot's "ack" comment is misleading because it reflects only one command.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Pending test outcomes and any other commentary. |
All looks good, hold cancel? |
/hold cancel |
@willie-yao: new pull request created: #3660 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@willie-yao: new pull request created: #3661 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This PR increases the AKS reconcile timeout to fix an issue where AKS upgrade tests are extremely flaky. We pinned the issue down to being related to the AKS PUT request taking too long (13-20 seconds), which is above our 12 second reconcile timeout.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: