Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase AKS reconcile timeout #3657

Merged

Conversation

willie-yao
Copy link
Contributor

@willie-yao willie-yao commented Jun 21, 2023

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
This PR increases the AKS reconcile timeout to fix an issue where AKS upgrade tests are extremely flaky. We pinned the issue down to being related to the AKS PUT request taking too long (13-20 seconds), which is above our 12 second reconcile timeout.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Increase AKS reconcile timeout

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2023
@willie-yao
Copy link
Contributor Author

/cherry-pick release-1.9
/cherry-pick release-1.8

@k8s-infra-cherrypick-robot

@willie-yao: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@willie-yao
Copy link
Contributor Author

cc @jackfrancis @nojnhuh

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4b6fe6ea0916b06e3cb151fdb5598a574a72de2c

@nojnhuh
Copy link
Contributor

nojnhuh commented Jun 21, 2023

I think the cherry-pick bot only likes one of these in a comment at a time :/

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

I think the cherry-pick bot only likes one of these in a comment at a time :/

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7059146) 53.74% compared to head (6db0ac2) 53.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3657   +/-   ##
=======================================
  Coverage   53.74%   53.74%           
=======================================
  Files         185      185           
  Lines       18595    18595           
=======================================
  Hits         9994     9994           
  Misses       8059     8059           
  Partials      542      542           
Impacted Files Coverage Δ
util/reconciler/defaults.go 100.00% <ø> (ø)
azure/services/managedclusters/managedclusters.go 75.43% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jackfrancis
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-aks

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I think the cherry-pick bot only likes one of these in a comment at a time

@nojnhuh I've done two /cherry-pick commands before and it's worked. I think the bot's "ack" comment is misleading because it reflects only one command.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@mboersma
Copy link
Contributor

mboersma commented Jun 22, 2023

/hold

Pending test outcomes and any other commentary.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@nawazkh
Copy link
Member

nawazkh commented Jun 22, 2023

All looks good, hold cancel?
Kudos Willie!

@mboersma
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0e9535b into kubernetes-sigs:main Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jun 22, 2023
@k8s-infra-cherrypick-robot

@willie-yao: new pull request created: #3660

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@willie-yao: new pull request created: #3661

In response to this:

/cherry-pick release-1.9
/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants