Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs on using Azure cni v1 using single NIC per node #3627

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Jun 14, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:

  • This PR adds documentation, manifests on using Azure CNI v1 with CAPZ using one NIC per node.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #3610

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Adds documentation on using Azure CNI v1 with CAPZ using one NIC per node.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e52424e) 54.05% compared to head (39d5ad7) 54.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3627   +/-   ##
=======================================
  Coverage   54.05%   54.05%           
=======================================
  Files         186      186           
  Lines       18833    18833           
=======================================
  Hits        10181    10181           
  Misses       8105     8105           
  Partials      547      547           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/book/src/topics/azure-cni-v1.md Outdated Show resolved Hide resolved
docs/book/src/topics/azure-cni-v1.md Outdated Show resolved Hide resolved
docs/book/src/topics/azure-cni-v1.md Outdated Show resolved Hide resolved
docs/book/src/topics/azure-cni-v1.md Outdated Show resolved Hide resolved
docs/book/src/topics/azure-cni-v1.md Outdated Show resolved Hide resolved
docs/book/src/topics/addons.md Outdated Show resolved Hide resolved
docs/book/src/topics/addons.md Outdated Show resolved Hide resolved
docs/book/src/topics/addons.md Outdated Show resolved Hide resolved
docs/book/src/topics/addons.md Outdated Show resolved Hide resolved
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Just one small change from my end.

docs/book/src/topics/addons.md Outdated Show resolved Hide resolved
@nawazkh nawazkh force-pushed the az-cni-v1-docs branch 2 times, most recently from 3cd62e3 to e004ddb Compare July 12, 2023 19:33
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(I think we might have to merge #3702 before the link checker will pass.)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: daf204f11d27fdbb39359757899636c24e0b9aed

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mboersma July 12, 2023 21:41
@CecileRobertMichon
Copy link
Contributor

(I think we might have to merge #3702 before the link checker will pass.)

the PR merged so you should be able to rebase now

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9813ce6f05d168b5daded3f90813f714951acdfa

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 50aea07778a9f94f118c68afa531866ddf6289ed

@k8s-ci-robot k8s-ci-robot merged commit 44734bb into kubernetes-sigs:main Jul 13, 2023
@nawazkh nawazkh deleted the az-cni-v1-docs branch August 31, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants