-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs on using Azure cni v1 using single NIC per node #3627
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3627 +/- ##
=======================================
Coverage 54.05% 54.05%
=======================================
Files 186 186
Lines 18833 18833
=======================================
Hits 10181 10181
Misses 8105 8105
Partials 547 547 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Just one small change from my end.
3cd62e3
to
e004ddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
(I think we might have to merge #3702 before the link checker will pass.)
LGTM label has been added. Git tree hash: daf204f11d27fdbb39359757899636c24e0b9aed
|
the PR merged so you should be able to rebase now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 9813ce6f05d168b5daded3f90813f714951acdfa
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 50aea07778a9f94f118c68afa531866ddf6289ed
|
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #3610
Special notes for your reviewer:
PR add azure cni e2e tests with one NIC per linux node #3508 should be merged before merging this PR.
cherry-pick candidate
TODOs:
Release note: