[release-1.8] optional flatcar tests will create a loadbalancer #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
nawazkh
force-pushed
the
add_lb_to_flatcar_tests_1.8
branch
from
f36d451 to
f3a0009
Compare
|
/test pull-cluster-api-provider-azure-capi-e2e-v1beta1 |
|
@CecileRobertMichon I am wondering if I got the cherry-pick right? |
|
/retitle [release-1.8] optional flatcar tests will create a loadbalancer |
k8s-ci-robot
changed the title
willie-yao
reviewed
May 23, 2023
|
/test pull-cluster-api-provider-azure-e2e-optional-v1beta1 |
- Set cloudControllerManager.caCertDir to `/usr/share/ca-certificates` - and check if loadbalancer can spin up successfully - add caCertDir to CCM in tiltfile - add Note about caCertDir to CCM in azure external docs
nawazkh
force-pushed
the
add_lb_to_flatcar_tests_1.8
branch
from
f3a0009 to
dfee675
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f67d8e36434586ec0836f06bb2e983e0c789b307
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: