Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install azure disk CSI driver Helm chart with CAAPH #3576

Closed
wants to merge 8 commits into from

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented May 18, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it: Install azure disk CSI driver Helm chart with CAAPH in e2e tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3736

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Install azure disk CSI driver Helm chart with CAAPH

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jont828 Jont828 force-pushed the caaph-azuredisk branch from ea797fd to 28ea88d Compare May 19, 2023 21:11
@k8s-ci-robot
Copy link
Contributor

@Jont828: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apidiff 94c9ba0 link false /test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-ci-entrypoint 94c9ba0 link true /test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-conformance 94c9ba0 link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-capi-e2e 94c9ba0 link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-verify 94c9ba0 link true /test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-e2e 94c9ba0 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-e2e-aks 94c9ba0 link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-build 94c9ba0 link true /test pull-cluster-api-provider-azure-build
pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts 94c9ba0 link false /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-with-ci-artifacts 94c9ba0 link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
pull-cluster-api-provider-azure-test 94c9ba0 link true /test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-apiversion-upgrade 94c9ba0 link false /test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jont828
Copy link
Contributor Author

Jont828 commented Oct 9, 2023

Closed in favor of #4109

@Jont828 Jont828 closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use CAAPH to install Helm charts in e2e tests
2 participants