-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tilt live reload for capz-controller-manager #3500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you for fixing this! I tested it locally and it seems to work.
I assume this was another victim of the distroless
update? We had to do a similar permissions hack for process.txt
.
LGTM label has been added. Git tree hash: a37e8f3d5f42649568b4f6cebcbef2426a8679cc
|
What changed in the distroless image? I think this issue was more related to the capz-controller-manager container now running as non-root. But since the Tilt-flavored image is built as root, then the tilt scripts and manager binary are all owned by root and not world-writeable which the live reload steps would need to run as non-root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it: This PR fixes an issue where Tilt was failing to perform live updates of capz-controller-manager due to insufficient permissions on the parent directory of the
manager
binary. This change moves the Tilt-specific files in the CAPZ container into a new/tilt
directory with world-writeable permissions so the non-root user running the container newly specified in #3399 is able to delete the oldmanager
binary.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3497
Special notes for your reviewer:
TODOs:
Release note: