Change default nat gateway IP name #3424
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
| @@ -128,11 +128,6 @@ func GenerateFrontendIPConfigName(lbName string) string { | |||
| return fmt.Sprintf("%s-%s", lbName, "frontEnd") | |||
| } | |||
|
|
|||
| // GenerateNatGatewayIPName generates a NAT gateway IP name. | |||
| func GenerateNatGatewayIPName(clusterName, subnetName string) string { | |||
There was a problem hiding this comment.
dead code
|
/test ls |
|
@CecileRobertMichon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-provider-azure-e2e-workload-upgrade |
|
This is a really clean change that addresses the problem, nice. /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 15b414fc25dbac9b6d09c20dc0865e4f8dc50ccc
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3424 +/- ##
==========================================
+ Coverage 51.65% 51.66% +0.01%
==========================================
Files 182 182
Lines 18104 18102 -2
==========================================
+ Hits 9351 9353 +2
+ Misses 8222 8218 -4
Partials 531 531
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
This is technically not a bug fix (but it does fix a specific scenario so one could argue it is) but for the sake of fixing our tests, should we cherry-pick? |
|
/cherry-pick release-1.8 |
|
@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@CecileRobertMichon: #3424 failed to apply on top of branch "release-1.8": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it: The default name for nat gateway IP is currently "pip-" + cluster name + subnet name. Since the default subnet name already contains cluster name, this can lead to very long and repetitive IP names, such as this one observed in tests:
This PR changes the default name to reuse the natgw name instead so the public IP name is consistent with the nat gateway it belongs too, and isn't so repetitive and long when cluster name is on the longer side.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3421
Special notes for your reviewer:
This should be backwards compatible since it's changing the default value but not touching existing clusters.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: