add missing create verb to AzureManagedCluster, AzureManagedMachinePool webhooks

[nojnhuh]

What type of PR is this?
/kind bug

What this PR does / why we need it:
I noticed the validating webhooks for AzureManagedCluster and AzureManagedMachinePool resources were never getting invoked when those resources were created. This PR adds the missing kubebuilder annotation to fix that.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer: I took a look through all the types to see if any others were missing and these were the only 2 I found.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Fixed a bug causing validating webhooks for AzureManagedCluster and AzureManagedMachinePool not to be invoked on create

[nojnhuh]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nojnhuh]

/cherry-pick release-1.8

[k8s-infra-cherrypick-robot]

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mboersma]

/lgtm

Nice catch! Were there any errors in the log, or did it just fail silently to invoke them on create?

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 17a2bb85a690c22e3ce7b0376b9fb6950d4807fb

[jackfrancis]

lol

[jackfrancis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CecileRobertMichon]

wow

[CecileRobertMichon]

... and the e2e test fails to apply the template now

[nojnhuh]

Nice catch! Were there any errors in the log, or did it just fail silently to invoke them on create?

The only indication from the logs was that the webhook request itself wasn't getting logged. I didn't see any related errors.

[nojnhuh]

... and the e2e test fails to apply the template now

Windows node pool name length check was erroneously looking at metadata.name instead of spec.name, just pushed a fix for that.

[jackfrancis]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e473088c5d84ec72fc76e930fca510d51403314d

[k8s-infra-cherrypick-robot]

@nojnhuh: #3352 failed to apply on top of branch "release-1.7":

Applying: add missing create verb to AzureManagedCluster, AzureManagedMachinePool webhooks
Using index info to reconstruct a base tree...
A	api/v1beta1/azuremanagedcluster_webhook.go
A	api/v1beta1/azuremanagedmachinepool_webhook.go
A	api/v1beta1/azuremanagedmachinepool_webhook_test.go
M	config/webhook/manifests.yaml
Falling back to patching base and 3-way merge...
Auto-merging exp/api/v1beta1/azuremanagedmachinepool_webhook_test.go
Auto-merging exp/api/v1beta1/azuremanagedmachinepool_webhook.go
CONFLICT (content): Merge conflict in exp/api/v1beta1/azuremanagedmachinepool_webhook.go
Auto-merging exp/api/v1beta1/azuremanagedcluster_webhook.go
Auto-merging config/webhook/manifests.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add missing create verb to AzureManagedCluster, AzureManagedMachinePool webhooks
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@nojnhuh: new pull request created: #3355

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.