Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to specify AZURE_CLOUD_PROVIDER_ROOT when running ci-entrypoint locally #3307

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Allow user to specify AZURE_CLOUD_PROVIDER_ROOT when running ci-entrypoint locally #3307

merged 1 commit into from
Mar 16, 2023

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Mar 15, 2023 •
edited
Loading

…

What type of PR is this?
/kind feature

What this PR does / why we need it:
Let user specify AZURE_CLOUD_PROVIDER_ROOT env var when running ci-entrypoint locally

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2023
@marosset
Copy link
Contributor Author

/assign @jackfrancis @CecileRobertMichon

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 15, 2023
@CecileRobertMichon
Copy link
Contributor

Commit / PR title has a typo, otherwise lgtm

@marosset marosset force-pushed the build-ccm-specify-acp-root branch from e04e21c to ca57a01 Compare March 15, 2023 20:27
@marosset marosset changed the title Allow user to specify AZURE_CLOUD_PREVIDER_ROOT when running ci-entrypoint locally Allow user to specify AZURE_CLOUD_PROVIDER_ROOT when running ci-entrypoint locally Mar 15, 2023
@marosset
Copy link
Contributor Author

marosset commented Mar 15, 2023 •
edited
Loading

Commit / PR title has a typo, otherwise lgtm

Fixed both :-/

CecileRobertMichon
CecileRobertMichon reviewed Mar 15, 2023
View reviewed changes
scripts/ci-build-azure-ccm.sh
@@ -38,12 +38,18 @@ export CNM_IMAGE_NAME=azure-cloud-node-manager
export WINDOWS_IMAGE_VERSION=1809
declare -a IMAGES=("${CCM_IMAGE_NAME}" "${CNM_IMAGE_NAME}")


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra whiteline

CecileRobertMichon

This comment was marked as duplicate.

Sign in to view

@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4af46c94a136ba2dd06d10e9047f4e5da7318d73

mboersma
mboersma approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2023
@nawazkh
Copy link
Member

nawazkh commented Mar 16, 2023

Seems like a flake, the last run was green.
/retest

@k8s-ci-robot
Copy link
Contributor

@marosset: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e ca57a01 link true /test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Contributor

Failing repetitively on #3227 :(

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2e012ad into kubernetes-sigs:main Mar 16, 2023
@CecileRobertMichon
Copy link
Contributor

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 21, 2023
Closed
@k8s-infra-cherrypick-robot
Copy link

@CecileRobertMichon: new pull request created: #3467

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@mboersma mboersma mboersma approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

Assignees

@mboersma mboersma

@jackfrancis jackfrancis

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marosset @CecileRobertMichon @k8s-ci-robot @nawazkh @k8s-infra-cherrypick-robot @mboersma @jackfrancis