Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't need a repo list for Windows 1.24+ #3295

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Don't need a repo list for Windows 1.24+ #3295

merged 1 commit into from
Mar 16, 2023

Conversation

jsturtevant
Copy link
Contributor

What type of PR is this?

The 1.24 job is failing due missing the etcd image: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-capz-master-containerd-windows-1-24/1635673910743666688.

This image was pointing to the Azure registry which was recently cleaned up. Since this image is available in upstream 1.23+ we can use that image which doesn't require custom images: https://github.com/kubernetes/kubernetes/pull/92433/commits/c4fc9bba6c292970f7f8e82b8033afbe31f07c9a 

The etcd image using in 1.24 is https://github.com/kubernetes/kubernetes/blob/v1.24.11/test/utils/image/manifest.go#L245 3.5.6-0 which does contain windows versions for 2019 and 2022

 ./regctl manifest get k8s.gcr.io/etcd:3.5.6-0   
Name:      k8s.gcr.io/etcd:3.5.6-0@sha256:3ddf898c18c4c68b1ebac8ec40973d041f9afd4ab4dfc46580df189a123fdb1d
  Digest:    sha256:3ddf898c18c4c68b1ebac8ec40973d041f9afd4ab4dfc46580df189a123fdb1d
  MediaType: application/vnd.docker.distribution.manifest.v2+json
  Platform:  windows/amd64/10.0.17763.3650
  OSVersion: 10.0.17763.3650   

Name:      k8s.gcr.io/etcd:3.5.6-0@sha256:088f58efd1a4008d11a63ddf25cafc2b78132fbab18281a48673b3ab2c6c8077
  Digest:    sha256:088f58efd1a4008d11a63ddf25cafc2b78132fbab18281a48673b3ab2c6c8077
  MediaType: application/vnd.docker.distribution.manifest.v2+json
  Platform:  windows/amd64/10.0.20348.1249
  OSVersion: 10.0.20348.1249

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2023
@jsturtevant
Copy link
Contributor Author

/cherry-pick release-1.8
/cherry-pick release-1.7

@k8s-infra-cherrypick-robot
Copy link

@jsturtevant: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-windows

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-ci-entrypoint
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-e2e-aks
  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-azure-apidiff
  • /test pull-cluster-api-provider-azure-apiversion-upgrade
  • /test pull-cluster-api-provider-azure-capi-e2e
  • /test pull-cluster-api-provider-azure-conformance
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-e2e-optional
  • /test pull-cluster-api-provider-azure-e2e-workload-upgrade
  • /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-ci-entrypoint
  • pull-cluster-api-provider-azure-conformance
  • pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify
  • pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts

In response to this:

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsturtevant
Copy link
Contributor Author

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot
Copy link

@jsturtevant: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts

@CecileRobertMichon
Copy link
Contributor

/cherry-pick release-1.7

fyi there's a bug where the bot only prints the confirmation for the first line but it does both when the PR merges so you don't actually need tow separate comments

@marosset
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4a1d8607913f910d45b9f0cd04ef1ef1a4d6aa3

@jsturtevant
Don't need a repo list for 1.24+
4d9ce38 
Signed-off-by: James Sturtevant <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot requested a review from marosset March 15, 2023 17:13
@marosset
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2023
@marosset
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 69ce8f9bd0de9cc5eb3a9b93bffeb3f12483093d

CecileRobertMichon
CecileRobertMichon reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@marosset
Copy link
Contributor

/restest

@marosset
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e

@mboersma
Copy link
Contributor

/retest

@CecileRobertMichon
Copy link
Contributor

flake on #3227

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9dba6f6 into kubernetes-sigs:main Mar 16, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 16, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@jsturtevant: new pull request created: #3316

In response to this:

/cherry-pick release-1.8
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 16, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@jsturtevant: new pull request created: #3318

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

@marosset marosset Awaiting requested review from marosset

Assignees

@CecileRobertMichon CecileRobertMichon

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jsturtevant @k8s-infra-cherrypick-robot @k8s-ci-robot @CecileRobertMichon @marosset @mboersma