Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nawazkh to reviewers list #3207

Merged
merged 1 commit into from
Mar 15, 2023
Merged

add nawazkh to reviewers list #3207

merged 1 commit into from
Mar 15, 2023

Conversation

jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Feb 28, 2023 •
edited by CecileRobertMichon
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR will add @nawazkh as a CAPZ reviewer.

According to the requirements defined here:

Nawaz has been involved throughout the CAPZ codebase, and notably has driven many CI improvements. Thank you Nawaz!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2023
@CecileRobertMichon
Copy link
Contributor

Enthusiastic +1, well deserved @nawazkh!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7653a48c7d224b869a841ecad744a999608c5da

@CecileRobertMichon
Copy link
Contributor

/hold for consensus

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
mboersma
mboersma reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I was literally just about to ask in Slack when @nawazkh was going to join the reviewers, then I got notified of this PR. Well deserved. Thanks for everything that you do @nawazkh!

@mboersma
Copy link
Contributor

/assign @devigned @Jont828 @jsturtevant @marosset @nojnhuh @sonasingh46

@sonasingh46
Copy link
Contributor

+1 Fantastic work @nawazkh. Thank you

@jsturtevant
Copy link
Contributor

+1 great to see the focus on automating and improving the quality of CI

@nojnhuh
Copy link
Contributor

nojnhuh commented Feb 28, 2023

+1, @nawazkh has been awesome at jumping in to pick up issues and review PRs. Looking forward to more!

@devigned
Copy link
Contributor

devigned commented Mar 1, 2023

+1 well earned!

@CecileRobertMichon
Copy link
Contributor

Should start a lazy consensus on this?

@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2023
@jackfrancis
Copy link
Contributor Author

Propose lazy consensus expiration after CAPZ office hours tomorrow (roughly 10 a.m. PST)

@CecileRobertMichon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2023
@CecileRobertMichon
Copy link
Contributor

/retest

4 similar comments
@CecileRobertMichon
Copy link
Contributor

/retest

@jackfrancis
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor

/retest

@mboersma
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit c30e021 into kubernetes-sigs:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma left review comments

@sonasingh46 sonasingh46 sonasingh46 approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

@devigned devigned

@jsturtevant jsturtevant

@CecileRobertMichon CecileRobertMichon

@nojnhuh nojnhuh

@Jont828 Jont828

@marosset marosset

@sonasingh46 sonasingh46

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jackfrancis @CecileRobertMichon @k8s-ci-robot @mboersma @sonasingh46 @jsturtevant @nojnhuh @devigned @Jont828 @marosset