Fix wrong LB idletimeout for node outbound

[CecileRobertMichon]

What type of PR is this?

/kind bug

What this PR does / why we need it: In cluster scope, when reading Control Plane outbound LB specs, IdleTimeoutInMinutes is read from node outbound LB spec instead from control plane outbound spec

cluster-api-provider-azure/azure/scope/cluster.go

Line 287 in 4964920

IdleTimeoutInMinutes: s.NodeOutboundLB().IdleTimeoutInMinutes,

, so this can cause a panic on the mentioned line in cluster scope when node outbound LB is nil.

Adds unit tests for the LBSpecs() func.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2812

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Fix idleTimeoutInMinutes for Control Plane Outbound LB to use the right LB spec

[CecileRobertMichon]

/assign @sonasingh46

[sonasingh46]

/retest

[sonasingh46]

PR looks good to me.
Re-triggered the failed test, timeout issue.

[nprokopic]

Looks great, thanks!

[CecileRobertMichon]

/cherry-pick release-1.6
/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

Could I get an /lgtm from one of you?

/assign @mboersma @jackfrancis

[mboersma]

/lgtm

🐛 Thank you for the unit test!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b9798c94ed9f50679b5a560ba423aa5fd426f0c2

[CecileRobertMichon]

/approve

self-approving since 1) this is a relatively small change (outside UTs) and fixes a user impacting bug 2) 3 people have reviewed and lgtm'ed including one project approver and one project reviewer

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: #3138 failed to apply on top of branch "release-1.6":

Applying: Fix wrong LB idletimeout for node outbound
Using index info to reconstruct a base tree...
M	azure/scope/cluster.go
M	azure/scope/cluster_test.go
Falling back to patching base and 3-way merge...
Auto-merging azure/scope/cluster_test.go
Auto-merging azure/scope/cluster.go
CONFLICT (content): Merge conflict in azure/scope/cluster.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix wrong LB idletimeout for node outbound
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: new pull request created: #3140

In response to this:

/cherry-pick release-1.6
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.